fix "strpos empty needle" warning #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue greenlion#320 a warning was issued in `PositionCalculator#findPositionWithinString` when calling `strpos` on an empty value: ``` Warning: strpos(): Empty needle in src/PHPSQLParser/positions/PositionCalculator.php on line 138 ``` => return `false` earlier in that case, to then throw an exception
|
You should use backticks around help - the parser requires keywords used as identifiers to be quoted with backticks. |
|
Test case fails on 5.4 with syntax error |
PHP Parse error: syntax error, unexpected 'class' (T_CLASS), expecting
identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in
/home/travis/build/greenlion/PHP-SQL-Parser/tests/cases/parser/issue320Test.php
on line 55
|
sorry, I did not see that failure at the time. I adapted the test so it passes on PHP 5.4. |
|
I am pretty busy with other projects right now, but I'll give this a cursory test ASAP and merge. Thanks for the contribution! |
|
Will this be merged? to and it may end up with some unexpected results... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #320
a warning was issued in
PositionCalculator#findPositionWithinStringwhen calling
strposon an empty value:=> return
falseearlier in that case, to then throw an exception